Skip to content

Refactor repacking of transformer structure#254

Merged
Jutho merged 2 commits intomasterfrom
ld-transformer
Jul 10, 2025
Merged

Refactor repacking of transformer structure#254
Jutho merged 2 commits intomasterfrom
ld-transformer

Conversation

@lkdvos
Copy link
Copy Markdown
Member

@lkdvos lkdvos commented Jul 9, 2025

This is a small improvement based on @Jutho's suggestion that avoids an intermediate allocation.

@Jutho
Copy link
Copy Markdown
Member

Jutho commented Jul 9, 2025

Perfect. While you are at it, would you mind renaming ids_... to inds_...? I don't care to much for abbreviations where random letters have been omitted 😄 .

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.90%. Comparing base (d68876b) to head (357cb46).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   82.90%   82.90%           
=======================================
  Files          44       44           
  Lines        5749     5751    +2     
=======================================
+ Hits         4766     4768    +2     
  Misses        983      983           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jutho
Copy link
Copy Markdown
Member

Jutho commented Jul 9, 2025

Strange errors; would this be a result of the Strided.jl changes, where copyto! no longer goes via Strided.jl. It seems some paths of Strided.mul! go to copyto!, which I should also have replaced with copy! statements. I will fix this asap.

@lkdvos
Copy link
Copy Markdown
Member Author

lkdvos commented Jul 9, 2025

Looking at the stacktraces I think this is indeed the issue: rmul!(stridedarray, 1) goes through copyto! which checks for aliasing.

@Jutho
Copy link
Copy Markdown
Member

Jutho commented Jul 10, 2025

Strided.jl v2.3.2 will be tagged/registered soon, so we can then rerun the tests.

@Jutho Jutho merged commit 0d5bb31 into master Jul 10, 2025
17 of 21 checks passed
@Jutho Jutho deleted the ld-transformer branch July 10, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants